TICL: Consolidate v5 as Default Configuration and Cleanup Legacy Code#49932
Merged
cmsbuild merged 29 commits intoMay 19, 2026
Conversation
Contributor
|
cms-bot internal usage |
Contributor
Author
|
@cmsbuild please test |
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49932/47681
|
Contributor
|
A new Pull Request was created by @felicepantaleo for master. It involves the following packages:
@AdrianoDee, @DickyChant, @Martin-Grunewald, @Moanwar, @antoniovagnerini, @civanch, @ctarricone, @davidlange6, @fabiocos, @ftenchini, @gabrielmscampos, @jfernan2, @kpedro88, @mandrenguyen, @mdhildreth, @miquork, @mmusich, @nothingface0, @rseidita, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
|
-1 Failed Tests: UnitTests Failed Unit TestsI found 1 errors in the following unit tests: ---> test testProduceNanoHLT had ERRORS Comparison SummarySummary:
Max Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 9 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
Contributor
Author
|
@cmsbuild please test |
cmsbuild
added
tests-started
code-checks-pending
and removed
tests-rejected
code-checks-approved
labels
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49932/47683
|
Contributor
Author
|
step2 v5 vs PR, ttbar PU200
step3 v5 vs PR, ttbar PU200
|
Contributor
Author
|
type ngt |
Contributor
@Moanwar if you are satisfied with the reconstruction changes feel free to sign for reco. |
Contributor
|
Hi @mmusich , welcome back. Well, from what has been shown so far, the PR looks to be in good shape. However, I thought it would still be better to check whether any additional tests might be needed, which is why I asked you. |
Contributor
not really, I will take some time to digest all the numbers and discussion above before signing for HLT. |
Contributor
looks like the PR tests are not available anymore |
Contributor
|
@cmsbuild, please test
|
Contributor
|
@smuzaffar tests look stuck here, can you have a look? |
Contributor
|
@cmsbuild, please abort |
Contributor
|
@cmsbuild, please test |
Contributor
|
+1 Size: This PR adds an extra 28KB to repository The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: HLT P2 Timing: chart Comparison SummarySummary:
Max Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 2 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
Contributor
|
Nice, I am not sure what changed, but the number of workflows above the memory threshold has dropped a lot since the last test. |
Contributor
|
For the record the change in timing is the following reported by the bot at #49932 (comment): HLT timing menu (on GPU)
The net time saving per event is 6288.0 ms - 5875.3ms = 412.7ms (i.e. HLT timing menu (on CPU)
The net time saving per event is 8513.0 ms -8079.9 ms = 433.1 ms (i.e. NGT scouting menu
The net time saving per event is 7414.5ms - 6836.7ms = 577.8ms (i.e. As expected the GPU memory usage is unvaried (within measurement uncertainties), e.g. log: 
|
Contributor
|
+hlt
|
Contributor
|
@felicepantaleo , just for my education, is it expected that e.g. in the "vanilla" Phase-2 workflow wf 34434.0, the HLT validation plots in |
Contributor
Author
|
@mmusich yes, the superclustering DNN efficiency is still low and the model needs retuning. It might be that the iteration has run, but for this tight configuration it did not find any supercluster. |
Contributor
Author
|
Could you please check this and sign? |
Contributor
|
+1
|
Member
|
+dqm |
Contributor
|
+1 |
Contributor
|
+pdmv |
Contributor
|
@cms-sw/ml-l2 your signature is required here. |
Contributor
|
+ml |
Contributor
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @mandrenguyen, @ftenchini (and backports should be raised in the release meeting by the corresponding L2) |
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR establishes TICL v5 as the default reconstruction configuration, removing the need for explicit process modifiers and cleaning up significant amounts of legacy code associated with previous versions.
Key Changes:
Core Configuration:
Updated
RecoHGCal/TICL/python/iterativeTICL_cff.pyto use the TICL v5 chain (CLUE3DHigh->TracksterLinks->TICLCandidate) by default.Removed fallback logic for v4.
Switched
CLUE3DHighStepto use PFN inference by default.Introduced
ticl_devprocess modifier for future development.C++ Plugins:
PFTICLProducer: Simplified logic by removing the
isTICLv5_switch. The default behavior now assumes TICL v5 timing fromTICLCandidate.PatternRecognition: Enabled
computeLocalTimeby default inPatternRecognitionbyCLUE3DandPatternRecognitionbyCA. EnabledusePCACleaningby default inPatternRecognitionbyCLUE3D.Validation & DQM:
Updated
HGCalValidatorto validateticlCandidateandticlTracksterLinkscollections by default.Updated
makeHGCalValidationPlots.pyto plot v5 collections.Updated
RecoHGCal_EventContent_cff.pyto consolidate keep statements for v5 collections.Fixed handling of empty collections in validator plugins.
Cleanup:
Removed obsolete process modifiers:
ticl_v4,ticl_v5,clue3D,fastJetTICL,enableCPfromPU.Removed deprecated Python configurations:
ticl_iterations.py,customiseForTICLv5_cff.py,customiseTICLFromReco.py.Removed legacy
TracksterInferenceByCNNv4implementation.Removed deprecated
harvestHGCalValidationPlots.pyscript.HLT & Workflows:
Updated HLT 75e33 and Scouting menus to use TICL v5 components.
Removed obsolete HLT modules (
hltParticleFlowSuperClusterHGCalFromTICLL1Seeded,hltParticleFlowSuperClusterHGCalFromTICLUnseeded).Updated PyReleaseValidation workflows to reflect the removal of the
ticl_v5modifier.Testing:
Notes:
This PR represents a major consolidation of the TICL configuration, simplifying the codebase and establishing a clean baseline for future developments.